Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add simsx labels & more #21776

Merged
merged 10 commits into from
Sep 18, 2024
Merged

chore: add simsx labels & more #21776

merged 10 commits into from
Sep 18, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 17, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Expanded ownership for the /simsx directory by adding designated code owners.
    • Introduced new audit items in the quality assurance checklist for enhanced review processes.
    • Improved pull request labeling by recognizing files within the simsx directory structure.
    • Added support for multisignature accounts in the module's functionality.
  • Bug Fixes

    • Updated existing audit item from "Audit x/simulation" to "Audit x/protocolpool" for better accuracy.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Sep 17, 2024
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

Walkthrough

The changes involve updates to several GitHub configuration files: .github/CODEOWNERS, .github/ISSUE_TEMPLATE/qa.md, and .github/pr_labeler.yml. The .github/CODEOWNERS file now includes the /simsx directory with designated code owners and expands ownership for the /tests/integration/aminojson directory. The .github/ISSUE_TEMPLATE/qa.md file has added new audit items and replaced an existing one to refine the auditing process. Additionally, the .github/pr_labeler.yml file has been updated to include new patterns for labeling pull requests associated with simulation files. The changelog and module files have also been modified to reflect new features and updates in dependency management.

Changes

File Change Summary
.github/CODEOWNERS Added /simsx with owners @alpe, @facundomedica, @kocubinski, @cosmos/sdk-core-dev; added /tests/integration/aminojson with owners @kocubinski, @cosmos/sdk-core-dev.
.github/ISSUE_TEMPLATE/qa.md Added * [ ] Audit x/bank/v2, * [ ] Audit x/epochs; renamed * [ ] Audit x/simulation to * [ ] Audit x/protocolpool.
.github/pr_labeler.yml Added - types/simulation/**/*, - simsx/**/* under the "C:Simulations" label.
core/CHANGELOG.md Added core/event as a type alias of schema/appdata for version v1.0.0-alpha.3.
core/go.mod Updated dependency comment to clarify module philosophy; changed require cosmossdk.io/schema v0.2.0 to v0.3.0.
go.work.example Added ./x/accounts/defaults/multisig to the import section.
indexer/postgres/go.mod Updated require cosmossdk.io/schema v0.1.1 to v0.3.0.
indexer/postgres/tests/go.mod Updated require cosmossdk.io/schema v0.1.1 to v0.3.0.
store/go.mod Removed toolchain go1.23.0 line; Go version remains go 1.23.

Possibly related PRs

Suggested labels

C:indexer/postgres

Suggested reviewers

  • alpe
  • facundomedica
  • kocubinski
  • cosmos/sdk-core-dev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt requested a review from a team as a code owner September 17, 2024 19:13
@julienrbrt julienrbrt changed the title chore: add simsx labels chore: add simsx labels & more Sep 17, 2024
@julienrbrt
Copy link
Member Author

I will wait before merging this until schema is tagged to bump it here in core.

Copy link
Contributor

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema version should be bumped before merge

@julienrbrt julienrbrt dismissed cool-develope’s stale review September 17, 2024 19:38

if you change to request change, I'll need to wait for you to merge this.

@julienrbrt julienrbrt added the S:blocked Status: Blocked label Sep 17, 2024
@github-actions github-actions bot added C:Store C:Hubl Tool: Hubl labels Sep 18, 2024
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Sep 18, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 355f66f Sep 18, 2024
73 checks passed
@julienrbrt julienrbrt deleted the julien/chores branch September 18, 2024 08:16
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
(cherry picked from commit 355f66f)

# Conflicts:
#	.github/CODEOWNERS
#	core/CHANGELOG.md
#	core/go.mod
#	core/go.sum
#	indexer/postgres/go.mod
#	indexer/postgres/tests/go.mod
#	store/go.mod
#	tools/hubl/go.mod
julienrbrt added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:Hubl Tool: Hubl C:indexer/postgres C:Store C:x/accounts/base C:x/accounts Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants