Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/v2/cometbft): wire app closer (backport #22240) #22250

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 14, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a new lifecycle management capability for the application with the addition of a closure for cleanup operations.
    • Expanded command-line interface with a new command for bootstrapping state.
    • Added methods for store access and application closure management in the SimApp.
  • Improvements

    • Enhanced resource management by ensuring proper closure of database connections.
  • Bug Fixes

    • Enhanced error handling in the testing framework to ensure robust validation of consensus methods.

This is an automatic backport of pull request #22240 done by [Mergify](https://mergify.com).

(cherry picked from commit 0b43fcc)

# Conflicts:
#	server/v2/testdata/app.toml
#	server/v2/types.go
#	store/v2/commitment/metadata.go
#	store/v2/root/factory.go
#	store/v2/root/migrate_test.go
#	store/v2/root/store.go
#	store/v2/root/store_test.go
#	store/v2/root/upgrade_test.go
@mergify mergify bot requested a review from a team as a code owner October 14, 2024 06:13
@mergify mergify bot added the conflicts label Oct 14, 2024
Copy link
Contributor Author

mergify bot commented Oct 14, 2024

Cherry-pick of 0b43fcc has failed:

On branch mergify/bp/release/v0.52.x/pr-22240
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 0b43fcc21.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/cometbft/abci_test.go
	modified:   server/v2/cometbft/server.go
	modified:   simapp/v2/app_di.go
	modified:   tools/confix/data/v2-app.toml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   server/v2/testdata/app.toml
	deleted by us:   server/v2/types.go
	deleted by us:   store/v2/commitment/metadata.go
	deleted by us:   store/v2/root/factory.go
	deleted by us:   store/v2/root/migrate_test.go
	deleted by us:   store/v2/root/store.go
	deleted by us:   store/v2/root/store_test.go
	deleted by us:   store/v2/root/upgrade_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added C:Store C:Confix Issues and PR related to Confix C:server/v2 Issues related to server/v2 C:server/v2 cometbft labels Oct 14, 2024
Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

@julienrbrt julienrbrt enabled auto-merge (squash) October 14, 2024 07:05
@julienrbrt julienrbrt merged commit 5ac8aae into release/v0.52.x Oct 14, 2024
68 of 70 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22240 branch October 14, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Confix Issues and PR related to Confix C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant