R4R: Validator Commission Model #2365

alexanderbez · 2018-09-20T15:44:38Z

Implement validator commission model:

Validator structure updated to include Commission as a first class citizen type
Create and edit validator messages handlers updated accordingly.
Update create-validator and edit-validator CLI commands.
Updated staking tx docs

closes: #1672
ref: #2236

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

ValarDragon · 2018-09-20T16:32:24Z

x/stake/types/validator.go

+	Commission              sdk.Dec   `json:"commission"`                 // the commission rate charged to delegators
+	CommissionMax           sdk.Dec   `json:"commission_max"`             // maximum commission rate which validator can ever charge
+	CommissionMaxChangeRate sdk.Dec   `json:"commission_max_change_rate"` // maximum daily increase of the validator commission
+	CommissionChangeToday   sdk.Dec   `json:"commission_change_today"`    // total commission rate change today (reset each day)


I don't think this variable is necessary. You can just limit a validator to one change every 24 hours, and when they do change validate its within the max change rate. You don't need to store the last delta change.

I was informed by @rigelrozanski that we would allow multiple changes a day as long as those changes are within the constraints of CommissionMaxChangeRate. Also, CommissionChangeToday is not new.

Are you suggesting we change and simplify the spec? This would things much easier to track.

I think I'll go with this approach for now that you're suggesting @ValarDragon -- I'll amend if @rigelrozanski suggests otherwise.

Awesome! Lets make a follow-up issue tagged postlaunch then

I have the PoV atm that lets table implementing convenience changes like that to postlaunch. (It is a good idea, but unnecessary atm)

Great suggestion - One change per day sounds fine if it will simplify the codebase :) - however we will of course still need to keep track of when the last change was made to check against - good improvement idea val!

codecov · 2018-09-20T17:50:38Z

Codecov Report

Merging #2365 into develop will increase coverage by 0.02%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #2365      +/-   ##
===========================================
+ Coverage    64.77%   64.79%   +0.02%     
===========================================
  Files          137      137              
  Lines         8469     8494      +25     
===========================================
+ Hits          5486     5504      +18     
- Misses        2620     2625       +5     
- Partials       363      365       +2

rigelrozanski

Good work! - few suggestions herein

x/stake/keeper/validator.go

x/stake/keeper/validator_test.go

x/stake/types/commission.go

x/stake/types/validator_test.go

x/stake/client/cli/utils.go

x/gov/tally_test.go

x/stake/client/cli/flags.go

x/stake/client/cli/utils.go

x/stake/keeper/validator.go

alexanderbez · 2018-09-24T15:29:57Z

@ValarDragon and @rigelrozanski address your comments 👍

rigelrozanski · 2018-09-24T22:23:42Z

dopeness

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.19...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - Update doc to follow Go conventions - Improve code readability * update params * rebase and fix nits * add GetMinGasPrice UT * remove unused feetestsuite * rebase * update doc * nits * nits * refactor fee tests setup * remove comments * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/ante/antetest/fee_test.go * fix GetMinGasPrice to not return nil coins * min gas price zero coins edge cases * min gas price zero coins edge cases * remove debug logs * udpate comments * udpate comments * add comment * Update x/globalfee/types/params.go Co-authored-by: yaruwangway <[email protected]> * Update x/globalfee/types/params.go Co-authored-by: yaruwangway <[email protected]> * fix: lint Signed-off-by: Yaru Wang <[email protected]> * refactor: global fee zero coins * refactor: add splitGlobalFees() * fix: globalfee antehandler * fix: add test helper func * update according to PR comments * test: add test for splitGlobalFees() * code improvement * refactor: globalfee antehandler * refactor: bypass logic * refactor: fee check logic * fix: lint * fix: return err when required fees are not set up * chore: clean comments * Sainoe/globalfee coins (cosmos#2378) * chore(deps): bump github.com/golangci/golangci-lint (cosmos#2319) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.2 to 1.52.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.51.2...v1.52.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Milan Mulji <[email protected]> * chore(deps): bump github.com/docker/docker (cosmos#2365) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.19...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removed trust node in docs (cosmos#2359) * update ditrosless image url in Dockerfiles * nits --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Milan Mulji <[email protected]> * fix nits --------- Signed-off-by: Yaru Wang <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Milan Mulji <[email protected]>

Update validator commission fields

0836abd

alexanderbez added C:x/staking prelaunch labels Sep 20, 2018

alexanderbez requested review from ValarDragon, rigelrozanski and cwgoes September 20, 2018 15:44

alexanderbez requested a review from ebuchman as a code owner September 20, 2018 15:44

ValarDragon reviewed Sep 20, 2018

View reviewed changes

Remove CommissionChangeToday and update to use CommissionChangeTime

2d3cbcd

Implement commission as a first class citizen type

06aacb9

Aleksandr Bezobchuk added 17 commits September 20, 2018 13:56

Implement stringer for Comission

d2f60c9

Move commission type and logic to new file

0bdbf8c

Add new commission errors

243ec85

Add commission to create validator message

f7e2f3b

Implement and call UpdateValidatorCommission

66094d1

Update godoc for UpdateValidatorCommission

d410639

Add Abs to the decimal type

e29414e

Implement new SetValidatorCommission

6403d19

Update decimal short godocs

e89b751

Move set initial commission logic

a0b55c6

Move initial commission validation to Commission type

4bc9070

Update initial validator commission logic and unit tests

cabcd3c

Remove commission update time from struct and move to validator

04945e4

Update validator create handler tests

6606348

Implement commission logic for CLI

a3947dc

Fix make lint failure

8b12742

Fix make cover failure

d743ba8

Aleksandr Bezobchuk added 6 commits September 21, 2018 12:34

Update edit validator logic to handle new commission rate

7f9f927

Fix lint and cover

8eb926d

Update create/edit validator simulation to include commission params

3aa7f5f

Update MsgEditValidator godoc

08dc442

Update pending log

d22c4d9

Update staking tx docs

089a279

alexanderbez requested a review from zramsay as a code owner September 21, 2018 17:48

Fix CLI create validator test

a3f0dc8

alexanderbez changed the title ~~WIP: Validator Commission Model~~ R4R: Validator Commission Model Sep 21, 2018

alexanderbez added ready-for-review and removed wip labels Sep 21, 2018

alexanderbez mentioned this pull request Sep 21, 2018

Include Validator Commission Parameters in Genesis/Export #2374

Closed

4 tasks

This was referenced Sep 22, 2018

R4R: Distr-PR-5 Implement Distribution #2236

Merged

R4R: Distr-PR-3 More staking hooks #2381

Merged

rigelrozanski suggested changes Sep 22, 2018

View reviewed changes

ValarDragon reviewed Sep 23, 2018

View reviewed changes

Aleksandr Bezobchuk added 5 commits September 24, 2018 10:15

Update variables names for commission strings

66c25aa

Merge UpdateTime into Commission type

307cb15

Update create-validator usage in docs

588a553

Update more docs with examples

a117fcf

More doc updates

f75029d

rigelrozanski approved these changes Sep 24, 2018

View reviewed changes

rigelrozanski merged commit 9dafa32 into develop Sep 24, 2018

rigelrozanski deleted the bez/1672-val-commission-model branch September 24, 2018 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R4R: Validator Commission Model #2365

R4R: Validator Commission Model #2365

alexanderbez commented Sep 20, 2018 •

edited

Loading

ValarDragon Sep 20, 2018

alexanderbez Sep 20, 2018 •

edited

Loading

alexanderbez Sep 20, 2018

ValarDragon Sep 20, 2018 •

edited

Loading

rigelrozanski Sep 21, 2018 •

edited

Loading

codecov bot commented Sep 20, 2018 •

edited

Loading

rigelrozanski left a comment

alexanderbez commented Sep 24, 2018

rigelrozanski commented Sep 24, 2018

R4R: Validator Commission Model #2365

R4R: Validator Commission Model #2365

Conversation

alexanderbez commented Sep 20, 2018 • edited Loading

ValarDragon Sep 20, 2018

Choose a reason for hiding this comment

alexanderbez Sep 20, 2018 • edited Loading

Choose a reason for hiding this comment

alexanderbez Sep 20, 2018

Choose a reason for hiding this comment

ValarDragon Sep 20, 2018 • edited Loading

Choose a reason for hiding this comment

rigelrozanski Sep 21, 2018 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Sep 20, 2018 • edited Loading

Codecov Report

rigelrozanski left a comment

Choose a reason for hiding this comment

alexanderbez commented Sep 24, 2018

rigelrozanski commented Sep 24, 2018

alexanderbez commented Sep 20, 2018 •

edited

Loading

alexanderbez Sep 20, 2018 •

edited

Loading

ValarDragon Sep 20, 2018 •

edited

Loading

rigelrozanski Sep 21, 2018 •

edited

Loading

codecov bot commented Sep 20, 2018 •

edited

Loading