baseapp: Move code from setters.go to options.go #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because these setters are intended to be used as options for baseapp.
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
baseapp/options.go
Outdated
| @@ -35,3 +37,75 @@ func SetMinimumFees(minFees string) func(*BaseApp) { | |||
| } | |||
| return func(bap *BaseApp) { bap.SetMinimumFees(fees) } | |||
| } | |||
|
|
|||
| // nolint - Setter functions | |||
| func (app *BaseApp) SetName(name string) { | |||
There was a problem hiding this comment.
Can we pretty please add new lines between the function definitions?
There was a problem hiding this comment.
The point of not doing that was to not have to write nolint a ton of times. If you prefer we can still change it, I don't have a preference
There was a problem hiding this comment.
Just add // nolint to the top of the file then.
alexanderbez
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because these setters are intended to be used as options for baseapp.
No changelog entry as this isn't external facing.
For Admin Use: