Move all binaries to examples #242
Conversation
| . $DIR/shunit2 | ||
|
|
||
| # TODO: how to handle this if we are not in the same directory | ||
| CLI_DIR=${DIR}/../../../../tests/cli |
There was a problem hiding this comment.
The $DIR command navigates to a directory relative to THIS bash file... So this shouldn't be an issue, alternatively (maybe more clearly) we could just make $DIR a function of the $GOPATH
There was a problem hiding this comment.
CLI_DIR=$GOPATH/src/github.com/cosmos/cosmos-sdk/tests/cli
There was a problem hiding this comment.
Looks better to me
There was a problem hiding this comment.
Maybe in a different repo, we would refer to the cosmos-sdk in vendor dir
| ./tests/cli/ibc.sh | ||
|
|
||
| test_tutorial: docs/guide/shunit2 | ||
| # wget "https://raw.githubusercontent.com/kward/shunit2/master/source/2.1/src/shunit2" |
There was a problem hiding this comment.
wait how are we retrieving wget now?
|
Okay generally, I'm a fan of the idea of the this consolidation, however I think there is to much useful code in the examples dir. I'd like to see the example Directory be disposable to the repo, aka nothing should be build to depend on its features, it should exclusively depend on the SDK. In this sense it's really examples only not automation which may want to get used by another repo. for starters |
|
I agree. I think this consolidation helps find pieces of one app that are general purpose and we have to refactor them out of the examples cleanly. Cmd basecoin commands is a good example We don't use wget anymore but I added the file directly to the repo. Jae said it was a security issue to wget on every test. Who knows what is in that repo. |
|
oh I see, okay yeah I guess that's fine, would have done the same, just wasn't sure about straight up copying a repo - looks good. |
|
Just noticed we have been using a bit of ambiguity around the language Another comment, I want to be able to bash test modules... right now it looks like maybe the only way to do that is to include those tests in the |
ethanfrey
force-pushed
the
feature/move_to_examples
branch
from
7dd5063
to
2887d0d
Compare
ethanfrey
changed the title
cref: #9812 ## Description This PR adds a CLI for querying all module accounts, `module-accounts`, in the auth module. Using this command would display all the account information, including human readable name of the module, module account address, account number, permissions, etc. This command would be especially useful for developers using cosmos-sdk as there are lots of instances where a developer would have to look into the module account, but only to do so by getting the module account address after getting the module name, hashing it and bech32fying it in the status quo. By using this command, users would be able to get a quick look on the list of all module accounts' information. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [x] reviewed tests and test coverage - [x] manually tested (if applicable)
Solution: - init cachestore on cachestore lazily. - cleanup some unused stuff. Update store/CHANGELOG.md Signed-off-by: yihuang <[email protected]>
Solution: - init cachestore on cachestore lazily. - cleanup some unused stuff. Update store/CHANGELOG.md Signed-off-by: yihuang <[email protected]>
Now with examples/eyes examples/counter and examples/basecoin that each are self-contained
All cli tests and installation belong to an example and are called from the main Makefile.
I think there are some dependencies between the examples (they import basecoin/cmd/commands....), which should be removed to make this cleaner (no dependencies on examples), and maybe some more cleanup.