Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Don't lock keys database on read only ops #2544

Closed
wants to merge 3 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 21, 2018

Leverage Tendermint's new dbm.NewGoLevelDBWithOpts() call to avoid locking a keys database on read-only operations. This allows piping gaiacli commands's stdouts and stdins.

Ref. #966

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 21, 2018

Codecov Report

Merging #2544 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2544      +/-   ##
===========================================
- Coverage    60.28%   60.27%   -0.02%     
===========================================
  Files          150      150              
  Lines         8589     8591       +2     
===========================================
  Hits          5178     5178              
- Misses        3067     3069       +2     
  Partials       344      344

@alessio alessio changed the title Don't lock keys on read only ops R4R: Don't lock keys on read only ops Oct 21, 2018
@alessio
Copy link
Contributor Author

alessio commented Oct 21, 2018

/cc @jackzampolin

@alessio alessio changed the title R4R: Don't lock keys on read only ops R4R: Don't lock keys database on read only ops Oct 21, 2018
@alessio alessio added the C:Keys Keybase, KMS and HSMs label Oct 21, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Oct 21, 2018

Do we want to test this with Voyager (cc @faboweb)?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and a comment, but otherwise, utACK 👍

client/keys/utils.go Outdated Show resolved Hide resolved
client/keys/utils.go Outdated Show resolved Hide resolved
client/keys/utils.go Show resolved Hide resolved
@alessio
Copy link
Contributor Author

alessio commented Oct 22, 2018

Let's merge this instead: #2489

@alessio alessio closed this Oct 22, 2018
@alessio alessio deleted the alessio/load-readonly-dbs branch October 22, 2018 17:41
@alessio alessio restored the alessio/load-readonly-dbs branch October 22, 2018 20:50
@alessio alessio deleted the alessio/load-readonly-dbs branch October 23, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants