R4R: Governance Proposal Refactor

[mossid]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

Split from: #2571

Common fields that can be used for different implementation of Proposal are extracted into ProposalBase.

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[sunnya97]

@mossid

ProposalQueue has been changed to InfoQueue so we don't have to unmarshal the whole proposal each time(consider the case where a TextProposal has a very long description)

Check out #2638. I think that is a cleaner solution to this issue.

Unlike ProposalInfo where it gets pruned after the VotingPeriod, Proposal is immutable after its creation, so the user can always query the Proposal.

Why do we want to remove the ProposalInfo after the voting period? I think there is valuable information in there that should continue to be queriable for posterity. The obvious one being Status (was the proposal accepted or rejected?)! But also the other three fields are useful as well.

Enact is called when the proposal passes. It is useful when the proposal needs to trigger an event automatically.

I like this. We should just add this to the Proposal interface as it already is.

[codecov]

Codecov Report

Merging #2613 into sunny/gov-proposals-queue-iterator will increase coverage by 0.12%.
The diff coverage is 66.66%.

@@                          Coverage Diff                           @@
##           sunny/gov-proposals-queue-iterator    #2613      +/-   ##
======================================================================
+ Coverage                                58.7%   58.82%   +0.12%     
======================================================================
  Files                                     152      152              
  Lines                                    9430     9434       +4     
======================================================================
+ Hits                                     5536     5550      +14     
+ Misses                                   3527     3515      -12     
- Partials                                  367      369       +2

[alexanderbez]

@sunnya97 is this more or less a dup of #2638? Can we maybe adapt concepts from one or the other and close one?

[cwgoes]

@mossid What's the status of this PR? Are these changes still desirable? If so, can we rebase it and I'll review - otherwise, let's close it.