Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Tendermint 0.26.0 #2633

Closed
wants to merge 2 commits into from
Closed

R4R: Tendermint 0.26.0 #2633

wants to merge 2 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Oct 30, 2018

Replaced by #2679 and #2681

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #2633 into develop will decrease coverage by 0.17%.
The diff coverage is 61.76%.

@@             Coverage Diff             @@
##           develop    #2633      +/-   ##
===========================================
- Coverage    58.82%   58.65%   -0.18%     
===========================================
  Files          152      152              
  Lines         9424     9435      +11     
===========================================
- Hits          5544     5534      -10     
- Misses        3510     3537      +27     
+ Partials       370      364       -6

@jaekwon jaekwon changed the title WIP Tendermint 0.26.0-rc0 R4R: Tendermint 0.26.0 Oct 31, 2018
@alessio
Copy link
Contributor

alessio commented Oct 31, 2018

Mmmm lots of tests still fail

baseapp/baseapp.go Show resolved Hide resolved
client/context/context.go Show resolved Hide resolved
@liamsi liamsi mentioned this pull request Oct 31, 2018
5 tasks
@jaekwon
Copy link
Contributor Author

jaekwon commented Nov 1, 2018

@alessio you may have to run dep ensure --update, or you can try nuking vendors.

@alexanderbez
Copy link
Contributor

@jaekwon Mind if I make a separate PR that simply addresses the amino API updates? The proof/verification logic can remain in this one after I merge/rebase?

The PR is pretty big and I think it'll be easier to review this way.

@jaekwon
Copy link
Contributor Author

jaekwon commented Nov 2, 2018

Yeah ok, sounds like that would help!

@cwgoes
Copy link
Contributor

cwgoes commented Nov 2, 2018

@alessio you may have to run dep ensure --update, or you can try nuking vendors.

They all also fail in CI though, which does do that.

@alexanderbez
Copy link
Contributor

I'll take over this PR and attempt to address those issues.

@alexanderbez alexanderbez mentioned this pull request Nov 4, 2018
5 tasks
@jaekwon jaekwon closed this Nov 5, 2018
@cwgoes cwgoes deleted the jae/tm0.26.0-rc0 branch November 5, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants