R4R: AnteHandler Cleanup #2950
Merged
R4R: AnteHandler Cleanup #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
wip
Type: Code Hygiene
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
rigelrozanski
approved these changes
Nov 29, 2018
ValarDragon
reviewed
Nov 29, 2018
ValarDragon
reviewed
Nov 29, 2018
ValarDragon
reviewed
Nov 29, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2950 +/- ##
========================================
Coverage 55.53% 55.53%
========================================
Files 120 120
Lines 8494 8494
========================================
Hits 4717 4717
Misses 3455 3455
Partials 322 322 |
alessio
reviewed
Nov 29, 2018
alessio
reviewed
Nov 29, 2018
alessio
approved these changes
Nov 29, 2018
cwgoes
approved these changes
Nov 29, 2018
ValarDragon
previously requested changes
Nov 30, 2018
There was a problem hiding this comment.
If we end up removing the account number / sequence number per #2952, this newly added error code is obsolete. (And is thus creating an unnecessary future breaking change) I propose instead just using ErrInternal
|
Updated @ValarDragon to use |
|
@alexanderbez Looks like this just needs a minor rebase? Glad to quickly once-over again after, then should be OK to merge. |
|
Yes, I'll fix asap. |
|
@cwgoes updated. I no longer think this warrants a pending log update. |
cwgoes
approved these changes
Dec 4, 2018
mircea-c
pushed a commit
that referenced
this pull request
Dec 5, 2018
* Add and use CodeInvalidAccountNumber in ante handler * Minor cleanup of ante handler * Add pending log entry * Spell check and more minor comment restructuring * Add additional CodeInvalidAccountNumber * Update validateAccNumAndSequence * Revert account number error in favor of CodeInternal * Update pending log * Fix pending log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeInternalfor invalid account numbersTargeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: