Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate-only option to withdraw-rewards #3050

Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Dec 9, 2018

  • Add generate-only option to gaiacli tx dist withdraw-rewards command
  • PR without Issue because it is trivial fix

before patch ( not working --generate-only option )

$ gaiacli tx dist withdraw-rewards --from=node0 --is-validator  --trust-node  --generate-only

>>> Committed at block 22 (tx hash: 4943F550B5F8C29BF30A0FD30BF9B0E0F78B7B9A6951A5F98C580B3003B8D52E, response: {Code:0 Data:[] Log:Msg 0:  Info: GasWanted:200000 GasUsed:4868 Tags:[{Key:[97 99 116 105 111 110] Value:[119 105 116 104 100 114 97 119 95 118 97 108 105 100 97 116 111 114 95 114 101 119 97 114 100 115 95 97 108 108] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0} {Key:[115 111 117 114 99 101 45 118 97 108 105 100 97 116 111 114] Value:[99 111 115 109 111 115 118 97 108 111 112 101 114 49 53 113 57 118 107 106 118 117 51 99 109 110 109 55 55 108 115 101 122 107 54 110 115 114 109 103 110 122 53 48 115 116 101 55 99 114 120 52] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}] Codespace: XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0})

after patch

$ gaiacli tx dist withdraw-rewards --from=node0 --is-validator  --trust-node --generate-only

>>> {"type":"auth/StdTx","value":{"msg":[{"type":"cosmos-sdk/MsgWithdrawValidatorRewardsAll","value":{"validator_addr":"cosmosvaloper15q9vkjvu3cmnm77lsezk6nsrmgnz50ste7crx4"}}],"fee":{"amount":[{"denom":"","amount":"0"}],"gas":"200000"},"signatures":null,"memo":""}}
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dongsam!

@fedekunze
Copy link
Collaborator

fedekunze commented Dec 10, 2018

before patch ( not working --generate-only option )

Is simulate failing too ? @dongsam

@cwgoes
Copy link
Contributor

cwgoes commented Dec 10, 2018

Is simulate failing too ? @dongsam

Unrelated to changes in this PR.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants