Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: added macos integration tests #3152

Merged
merged 6 commits into from
Dec 19, 2018
Merged

Conversation

mircea-c
Copy link

Closes #2498

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3152 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3152      +/-   ##
===========================================
- Coverage    55.03%   55.01%   -0.02%     
===========================================
  Files          133      133              
  Lines         9427     9434       +7     
===========================================
+ Hits          5188     5190       +2     
- Misses        3922     3927       +5     
  Partials       317      317

@jackzampolin jackzampolin changed the title R4R: added macos integrationn tests R4R: added macos integration tests Dec 18, 2018
@mircea-c
Copy link
Author

Only running the basic integration test and fast simulation, can add more if required.

I think we should also only run this on develop and master branch as we have a limited amount of minutes for macos testing right now. I haven't implemented that filtering as of yet, but it's a simple change.

@mircea-c
Copy link
Author

Changed my mind, added branch filtering from the get go. Successful tests of the macos ci can be found here:

https://circleci.com/gh/cosmos/cosmos-sdk/61434

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just want to test that the binary compiles on mac, which this does. Not against also running basic tests on mac too, but this looks good.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@mircea-c
Copy link
Author

Great. I removed the examples tests. I'm leaving the integration and fast sim for sanity 😄

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mo tests, mo betta

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, great to test this now - thanks @mircea-c!

@jackzampolin jackzampolin merged commit c02043e into develop Dec 19, 2018
@jackzampolin jackzampolin deleted the mircea/gaiad-macos-ci-2498 branch December 19, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants