-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: build gaia docker image during CI #3282
Conversation
A long running request of mine. Thank you very much for this PR @mircea-c ! |
Codecov Report
@@ Coverage Diff @@
## develop #3282 +/- ##
===========================================
+ Coverage 55.2% 55.34% +0.13%
===========================================
Files 134 135 +1
Lines 9526 9597 +71
===========================================
+ Hits 5259 5311 +52
- Misses 3936 3954 +18
- Partials 331 332 +1 |
Can we also make this push docker tags for git tags and update |
I'll see if we can push tags easily. As for |
Do we want to do this on every branch? Was there a simulation requirement for that? Otherwise just building on push to |
@mircea-c good point. In my view, we should have one tag for latest |
@cwgoes Other than |
OK, I've changed it so that it only builds on pushes to @jackzampolin any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
LGTM but will let @jackzampolin give a final review. |
Yeah this works for me for now, Ideally we get artifacts for each commit tagged appropriately (i.e. for releases and tags, as well as develop and master), but this is a great start and we can easily add more here later. Going to go ahead and merge this. |
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: