Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: build gaia docker image during CI #3282

Merged
merged 4 commits into from
Jan 14, 2019
Merged

Conversation

mircea-c
Copy link

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work. DevOps issue #147
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin
Copy link
Member

A long running request of mine. Thank you very much for this PR @mircea-c !

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #3282 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3282      +/-   ##
===========================================
+ Coverage     55.2%   55.34%   +0.13%     
===========================================
  Files          134      135       +1     
  Lines         9526     9597      +71     
===========================================
+ Hits          5259     5311      +52     
- Misses        3936     3954      +18     
- Partials       331      332       +1

@jackzampolin
Copy link
Member

Can we also make this push docker tags for git tags and update latest every time too? 🙏

.circleci/config.yml Outdated Show resolved Hide resolved
@alessio alessio self-requested a review January 12, 2019 14:05
@mircea-c
Copy link
Author

Can we also make this push docker tags for git tags and update latest every time too?

I'll see if we can push tags easily.

As for latest I'm not convinced that's useful. Which version should it be pointing to? Latest develop build, a separate branch/tag specifically created for latest?

@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2019

Do we want to do this on every branch? Was there a simulation requirement for that?

Otherwise just building on push to develop and master seems fine to me.

@alessio
Copy link
Contributor

alessio commented Jan 14, 2019

@mircea-c good point. In my view, we should have one tag for latest stable and one for latest develop. So how about stable and develop?

@alessio
Copy link
Contributor

alessio commented Jan 14, 2019

Do we want to do this on every branch?

@cwgoes Other than master and develop, I don't think we need tags for other branches.

@mircea-c
Copy link
Author

OK, I've changed it so that it only builds on pushes to master and develop. The tags reflect the latest commit to either of those branches .

@jackzampolin any thoughts?

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2019

LGTM but will let @jackzampolin give a final review.

@jackzampolin
Copy link
Member

Yeah this works for me for now, Ideally we get artifacts for each commit tagged appropriately (i.e. for releases and tags, as well as develop and master), but this is a great start and we can easily add more here later. Going to go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants