R4R: Use dash-separated flags for minimus gas prices #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## develop #3364 +/- ##
===========================================
+ Coverage 54.9% 54.93% +0.02%
===========================================
Files 132 132
Lines 9645 9645
===========================================
+ Hits 5296 5298 +2
+ Misses 4016 4014 -2
Partials 333 333 |
| @@ -16,7 +16,7 @@ const defaultConfigTemplate = `# This is a TOML config file. | |||
| # The minimum gas prices a validator is willing to accept for processing a | |||
| # transaction. A transaction's fees must meet the minimum of each denomination | |||
| # specified in this config (e.g. 0.01photino,0.0001stake). | |||
| minimum_gas_prices = "{{ .BaseConfig.MinGasPrices }}" | |||
| minimum-gas-prices = "{{ .BaseConfig.MinGasPrices }}" | |||
There was a problem hiding this comment.
So is this required? This is why I didn't go with this in the first place because most (all?) toml keys are snake-cased.
There was a problem hiding this comment.
That is true for Tendermint config.toml, not for gaiad.toml.
There was a problem hiding this comment.
You're right...TOML spec doesn't really seem to have a preference here (https://github.com/toml-lang/toml#user-content-keys)
|
@alessio can you add a pending log entry? |
|
@alexanderbez done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3241
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: