Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Upgrade to go 1.11.5 #3464

Merged
merged 1 commit into from
Feb 1, 2019
Merged

R4R: Upgrade to go 1.11.5 #3464

merged 1 commit into from
Feb 1, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 31, 2019 •
edited
Loading

Rationale: fixes upstream issue golang/go#29903

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #3464 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3464   +/-   ##
========================================
  Coverage    59.47%   59.47%           
========================================
  Files          135      135           
  Lines         9981     9981           
========================================
  Hits          5936     5936           
  Misses        3673     3673           
  Partials       372      372

cwgoes
cwgoes suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some scripts and docs which also need to be updated, search for 1.11.4 - and also PENDING.md.

@alessio
Copy link
Contributor Author

alessio commented Jan 31, 2019

@cwgoes done

@cwgoes cwgoes merged commit 45d59b0 into develop Feb 1, 2019
@cwgoes cwgoes deleted the alessio/go-1.11.5 branch February 1, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @jackzampolin @cwgoes