Account for Rounding Errors in Distribution Calculations #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
changed the title
Codecov Report
@@ Coverage Diff @@
## release/v0.34.0 #4094 +/- ##
===================================================
- Coverage 60.02% 59.99% -0.04%
===================================================
Files 212 212
Lines 15121 15129 +8
===================================================
Hits 9077 9077
- Misses 5421 5429 +8
Partials 623 623 |
|
Passes |
alexanderbez
added
C:x/distribution
alexanderbez
approved these changes
Apr 10, 2019
jackzampolin
approved these changes
Apr 10, 2019
|
All seeds passed! |
cwgoes
reviewed
Apr 11, 2019
| currentStake := val.TokensFromShares(del.GetShares()) | ||
| if stake.GT(currentStake) { | ||
| panic(fmt.Sprintf("calculated final stake for delegator %s greater than current stake: %s, %s", | ||
| del.GetDelegatorAddr(), stake, currentStake)) | ||
| // account for rounding errors due to stake being multiplied by slash fractions |
There was a problem hiding this comment.
Why would these rounding errors lead to stake being too high, if we round up the slash fractions?
cwgoes
reviewed
Apr 11, 2019
| updatedFraction := sdk.OneDec().Sub(currentMultiplicand.Mul(newMultiplicand)) | ||
|
|
||
| // using MulTruncate here conservatively increases the slashing amount | ||
| updatedFraction := sdk.OneDec().Sub(currentMultiplicand.MulTruncate(newMultiplicand)) |
There was a problem hiding this comment.
++, this looks fine to me - this should lead to more slashing, see comment above
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4088
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: