Cherry pick 4135 v0.34.2 #4181
Merged
Cherry pick 4135 v0.34.2 #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## release/v0.34.2 #4181 +/- ##
==================================================
Coverage ? 59.99%
==================================================
Files ? 212
Lines ? 15129
Branches ? 0
==================================================
Hits ? 9077
Misses ? 5429
Partials ? 623 |
fedekunze
approved these changes
Apr 24, 2019
jackzampolin
approved these changes
Apr 24, 2019
jackzampolin
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Merge PR #4163: Fix v0.33.x export script to port gov data correctly * Remove TOC * Add missing changelog entry for v0.34.1 * Merge PR #4182: Cherry pick #4083 into v0.34.2 * Merge PR #4181: Cherry pick 4135 v0.34.2 * Merge PR #4183: Cherry pick 4181 into v0.34.2 * Support pagination and status query params for /staking/validators * Rename BondStatusToString to String * Cherry pick 4181 * Remove pending log * Fix CODEOWNERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks #4135 already on
developto v0.34.2.Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: