Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rewards and commission tags #4207

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Add rewards and commission tags #4207

merged 1 commit into from
Apr 26, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 26, 2019 •
edited
Loading

Add rewards and commission tags to their respective txs.

closes: #3850

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added ready-for-review C:x/distribution distribution module related labels Apr 26, 2019
rigelrozanski
rigelrozanski approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luks good

@alexanderbez alexanderbez merged commit ec4a1e8 into master Apr 26, 2019
@alexanderbez alexanderbez deleted the 3850-include-rewards-in-withdraw-tx branch April 26, 2019 23:11
@faboweb
Copy link
Contributor

faboweb commented Apr 27, 2019

Nice

alexanderbez added a commit that referenced this pull request May 3, 2019
@alexanderbez
Merge PR #4207: Add rewards and commission tags in txs
9ac4730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return the rewards amount on withdraw tx responses
4 participants
@alexanderbez @faboweb @rigelrozanski @fedekunze