Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation: Allow the use of a custom genesis time #4750

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Simulation: Allow the use of a custom genesis time #4750

merged 2 commits into from
Jul 19, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 19, 2019 •
edited
Loading

closes: #4747

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8af2230). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4750   +/-   ##
========================================
  Coverage          ?   53.7%           
========================================
  Files             ?     273           
  Lines             ?   17277           
  Branches          ?       0           
========================================
  Hits              ?    9279           
  Misses            ?    7314           
  Partials          ?     684

@alexanderbez alexanderbez marked this pull request as ready for review July 19, 2019 19:37
@alexanderbez alexanderbez added R4R and removed WIP labels Jul 19, 2019
colin-axner
colin-axner approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackzampolin jackzampolin merged commit 3c82254 into master Jul 19, 2019
@alexanderbez alexanderbez deleted the bez/4747-sim-genesis-time branch July 23, 2019 22:19
alexanderbez added a commit that referenced this pull request Jul 23, 2019
@alexanderbez
Merge PR #4750: Allow the use of a custom genesis time in simulations
9a8d517
@alexanderbez alexanderbez mentioned this pull request Oct 7, 2019
Merged
5 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez @jackzampolin
Merge PR cosmos#4750: Allow the use of a custom genesis time in simul…
4c451f4 
…ations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@colin-axner colin-axner colin-axner approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

Assignees
No one assigned
Labels
C:Simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulation: Custom Genesis File Time
3 participants
@alexanderbez @jackzampolin @colin-axner