Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort JSON during migration #4768

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Sort JSON during migration #4768

merged 1 commit into from
Jul 23, 2019

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin jackzampolin merged commit 309dacc into master Jul 23, 2019
@jackzampolin jackzampolin deleted the bez/sort-migration-json branch July 23, 2019 20:08
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4768 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4768   +/-   ##
=======================================
  Coverage   53.88%   53.88%           
=======================================
  Files         270      270           
  Lines       17230    17230           
=======================================
  Hits         9285     9285           
  Misses       7261     7261           
  Partials      684      684

alexanderbez added a commit that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants