Query genesis transactions

[colin-axner]

fixes #3867

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

• Re-reviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[colin-axner]

This pr is stuck on import cycle mentioned in #4785, my fix just pushed the import cycle off of build to tests..

[fedekunze]

imports github.com/cosmos/cosmos-sdk/x/staking/types
imports github.com/cosmos/cosmos-sdk/x/supply

Seems that we'll have to either create a mocked stakingtypes.MsgCreateValidator on genutils or a mocked supply.Supply for the expected keeper on staking

[alexanderbez]

Seems like a mocked supply is better, no?

[colin-axner]

Seems like a mocked supply is better, no?

Agree, but just to make sure I follow, add SupplyI interface to x/supply/exported/exported.go?

Also, should this be a separate issue/pr?

[colin-axner]

After playing around with this for a while, I am still not sure how to do this fix. I tried adding SupplyI to supplies exported but then I get a lot of issues with Supply not implementing pointer receiver functions Inflate/Deflate because NewSupply/DefaultSupply don't return a pointer nor is supply usually used as a pointer. I think I need a bit more direction on how to do this

Edit: Supply was updated to be an interface instead of a concrete type. SupplyI is now used instead of Supply

[alexanderbez]

@colin-axner I've made some (incomplete) updates that I believe are in the direction of what we want. I've implemented the SupplyI interface and removed all pointer receivers.

I haven't finished the implementation, but it should give you the general idea on what else needs to be done ⚡️

[codecov]

Codecov Report

Merging #4788 into master will decrease coverage by 0.01%.
The diff coverage is 64.51%.

@@            Coverage Diff             @@
##           master    #4788      +/-   ##
==========================================
- Coverage   54.21%   54.19%   -0.02%     
==========================================
  Files         269      269              
  Lines       17179    17189      +10     
==========================================
+ Hits         9313     9315       +2     
- Misses       7176     7184       +8     
  Partials      690      690

[alexanderbez]

Small nit, but otherwise LGTM ⚡️

[alexanderbez]

ACK

[fedekunze]

Thanks @colin-axner! we forgot to update the spec tho

[colin-axner]

Thanks @colin-axner! we forgot to update the spec tho

can you point me to where it is out of date?