Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckTx msg routing #4810

Merged
merged 5 commits into from
Jul 30, 2019
Merged

CheckTx msg routing #4810

merged 5 commits into from
Jul 30, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 30, 2019

Fixes: #4639

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #4810 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4810      +/-   ##
==========================================
- Coverage    50.5%   50.49%   -0.02%     
==========================================
  Files         288      288              
  Lines       18518    18516       -2     
==========================================
- Hits         9353     9349       -4     
- Misses       8480     8482       +2     
  Partials      685      685

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 1765613 into master Jul 30, 2019
@alexanderbez alexanderbez deleted the fedekunze/4639-checktx-msg-routing branch July 30, 2019 16:11
alexanderbez pushed a commit that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckTx doesn't verify message routing
2 participants