Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R Fix a bunch of broken/incorrect links #4829

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

@alexanderbez alexanderbez added the T:Docs Changes and features related to documentation. label Aug 1, 2019
@alexanderbez alexanderbez merged commit fd92504 into master Aug 1, 2019
@alexanderbez alexanderbez deleted the rigel/doc-link-fix branch August 1, 2019 18:02
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #4829 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4829      +/-   ##
==========================================
- Coverage   54.21%   54.19%   -0.02%     
==========================================
  Files         269      269              
  Lines       17179    17179              
==========================================
- Hits         9313     9311       -2     
- Misses       7176     7178       +2     
  Partials      690      690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants