Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.37.0 rc2 cherry picks #4931

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 20, 2019

Cherry pick the following PRs from master:


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Contributor Author

/cc @tnachen. Here I've cherry picked two non-breaking commits from master into the v0.37.0 line.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #4931 into rc2/v0.37.0 will decrease coverage by <.01%.
The diff coverage is 25%.

@@               Coverage Diff               @@
##           rc2/v0.37.0    #4931      +/-   ##
===============================================
- Coverage        51.06%   51.05%   -0.01%     
===============================================
  Files              290      290              
  Lines            18802    18801       -1     
===============================================
- Hits              9601     9599       -2     
- Misses            8508     8509       +1     
  Partials           693      693

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒

@fedekunze
Copy link
Collaborator

@alexanderbez can you update the description with the PRs that we should include in this cherry-pick?

@alexanderbez alexanderbez merged commit 87067e4 into rc2/v0.37.0 Aug 21, 2019
@alexanderbez alexanderbez deleted the bez/v0.37.0-rc2-cherry-picks branch August 21, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants