Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecheckTx Optimizations #5196

Merged
merged 23 commits into from
Oct 23, 2019
Merged

RecheckTx Optimizations #5196

merged 23 commits into from
Oct 23, 2019

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Oct 15, 2019

closes: #4933


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator

@AdityaSripal tests are failing

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry & unit tests would be ideal to test the new mode in addition to fixing the existing unit tests 👍

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #5196 into master will decrease coverage by 0.01%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##           master    #5196      +/-   ##
==========================================
- Coverage   53.55%   53.54%   -0.02%     
==========================================
  Files         290      290              
  Lines       17719    17738      +19     
==========================================
+ Hits         9489     9497       +8     
- Misses       7489     7502      +13     
+ Partials      741      739       -2

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

CHANGELOG.md Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AdityaSripal. Take a look at @fedekunze's comments

CHANGELOG.md Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
x/auth/ante/sigverify.go Outdated Show resolved Hide resolved
types/context.go Show resolved Hide resolved
baseapp/baseapp.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Show resolved Hide resolved
baseapp/baseapp.go Show resolved Hide resolved
docs/core/baseapp.md Outdated Show resolved Hide resolved
docs/core/baseapp.md Outdated Show resolved Hide resolved
runTxModeSimulate runTxMode = iota
// Deliver a transaction
runTxModeDeliver runTxMode = iota
runTxModeCheck runTxMode = iota // Check a transaction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runTxModeCheck runTxMode = iota // Check a transaction
runTxModeCheck runTxMode = iota + 1 // Check a transaction

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? This is ineffectual.

@alexanderbez alexanderbez merged commit 4cd18bc into master Oct 23, 2019
@alexanderbez alexanderbez deleted the aditya/recheck branch October 23, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckTx: Support ReCheck
4 participants