Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.37.5-rc2 🍒 Picks (Final) #5487

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

alexanderbez
Copy link
Contributor

Cherry-pick the following from master:


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #5487 into rc2/v0.37.5 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           rc2/v0.37.5    #5487      +/-   ##
===============================================
- Coverage        51.27%   51.26%   -0.02%     
===============================================
  Files              290      290              
  Lines            18873    18873              
===============================================
- Hits              9678     9676       -2     
- Misses            8502     8504       +2     
  Partials           693      693

@alexanderbez alexanderbez merged commit 09705d9 into rc2/v0.37.5 Jan 7, 2020
@alexanderbez alexanderbez deleted the rc2/cherry-picks/v0.37.5 branch January 7, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants