Remove acknowledgement interface in favour of []byte #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2020
cwgoes
force-pushed
the
cwgoes/ics-20-impl-work-contd
branch
from
fe73e87
to
45a4b2c
Compare
cwgoes
changed the title
cwgoes
requested review from
alessio,
alexanderbez,
fedekunze and
jackzampolin
as code owners
| @@ -64,6 +64,8 @@ func handlePacketDataTransfer( | |||
| if err := k.ReceiveTransfer( | |||
| ctx, packet.SourcePort, packet.SourceChannel, packet.DestinationPort, packet.DestinationChannel, data, | |||
| ); err != nil { | |||
| // How do we want to handle this case? Maybe we should be more lenient, it's safe to leave the channel open I think. | |||
jackzampolin
approved these changes
Feb 18, 2020
fedekunze
approved these changes
Feb 18, 2020
Co-Authored-By: Federico Kunze <[email protected]>
fedekunze
added a commit
that referenced
this pull request
Feb 20, 2020
* Add comments, remove unused code and attempt to point to places where the spec is being implemented * close channel when transfer fails * rename packer data transfer to align to spec; refactor table tests * ICS 20 implementation cleanup work (#5602) * Simulation docs (#5033) * simulation docs * update docs with the latest simulation changes * minor imporvments * clean up of simulation.md * expand section on weights * minor reword * minor wording fix Co-authored-by: Marko <[email protected]> * Merge PR #5597: Include Amount in Complete Unbonding/Redelegation Events * Add bank alias for gaia * Moar bank alias gaia * Moar bank alias gaia * Call `TimeoutExecuted`, add wrappers * Remove unused `MsgRecvPacket` Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Jack Zampolin <[email protected]> * Merge PR #5603: Remove acknowledgement interface in favour of []byte * fixes and cleanup * spec compliance * refactor relay prefixes and tests * Fix test compilation * cleanup; add notes and additional test case * Receive transfer test * Apply suggestions from code review Co-Authored-By: Bot from GolangCI <[email protected]> * Fix autolinter application * Add testcase with incorrect prefix * golangcibot fixes * delete extra comment Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Christopher Goes <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Bot from GolangCI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5509