Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min-height and max-height filters to TxSearch #5648

Merged
merged 3 commits into from
Feb 17, 2020

Conversation

gagbo
Copy link
Contributor

@gagbo gagbo commented Feb 14, 2020

Closes: #5638

Description

Allow REST server to allow clients to query for a minimum and/or maximum height in transactions


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@gagbo
Copy link
Contributor Author

gagbo commented Feb 14, 2020

I'm not sure if I should add doc in any spec file so I didn't check it.

I definitely did not check if my const are correct regarding GoDoc, I'll do this hopefully before monday.

I definitely did not add changelog, but I'll make it if you're okay with the key I chose

I didn't write tests, I just wanted to check the changes in my local client but it's still syncing. Any pointers for test writing is welcome

@gagbo gagbo force-pushed the feature/min_max_txheight_filters branch from 3a8d956 to 5f762c9 Compare February 17, 2020 08:32
@gagbo
Copy link
Contributor Author

gagbo commented Feb 17, 2020

I don't understand why the ci/circleci: proto test is failing though. Is that because the TxMinHeightKey and TxMaxHeightKey constants are exported ?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- Thanks @gagbo!

WRT to proto, don't worry about this. The issue is due to the fact that the PR is from a forked remote. We should probably look into how to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search transaction usability
4 participants