Remove dependency of types/module package on x/simulation #5835

jgimeno · 2020-03-19T15:14:02Z

Closes: #5724

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/auth/simulation/params.go

simapp/helpers/test_helpers.go

x/simulation/operation.go

x/simulation/params.go

x/simulation/simulate.go

x/params/module.go

x/mint/simulation/params.go

…dependency

jgimeno · 2020-03-20T12:11:52Z

@alessio, @fedekunze can you take a look if you see something weird? The dependency is removed now and compiles.

…f github.com:cosmos/cosmos-sdk into jonathan/5724-module-simulation-top-level-dependency

…dependency

codecov · 2020-03-20T15:52:08Z

Codecov Report

Merging #5835 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #5835   +/-   ##
=======================================
  Coverage   32.32%   32.32%           
=======================================
  Files         353      353           
  Lines       39465    39465           
=======================================
  Hits        12759    12759           
  Misses      25434    25434           
  Partials     1272     1272

Impacted Files	Coverage Δ
types/module/module.go	`96.15% <ø> (ø)`	⬆️
types/module/simulation.go	`0% <ø> (ø)`	⬆️
x/gov/types/content.go	`100% <ø> (ø)`	⬆️
x/auth/module.go	`50% <0%> (ø)`	⬆️
x/bank/module.go	`46% <0%> (ø)`	⬆️
x/distribution/module.go	`54.09% <0%> (ø)`	⬆️
x/mint/module.go	`49.01% <0%> (ø)`	⬆️
x/slashing/module.go	`55% <0%> (ø)`	⬆️
simapp/utils.go	`22.03% <0%> (ø)`	⬆️
x/staking/module.go	`50.76% <0%> (ø)`	⬆️
... and 2 more

…dependency

codecov · 2020-03-20T17:56:02Z

Codecov Report

Merging #5835 into master will not change coverage.
The diff coverage is 5.4%.

@@           Coverage Diff           @@
##           master    #5835   +/-   ##
=======================================
  Coverage   32.32%   32.32%           
=======================================
  Files         353      353           
  Lines       39476    39476           
=======================================
  Hits        12760    12760           
  Misses      25440    25440           
  Partials     1276     1276

Impacted Files	Coverage Δ
types/module/simulation.go	`0% <ø> (ø)`	⬆️
types/module/module.go	`96.15% <ø> (ø)`	⬆️
x/gov/types/content.go	`100% <ø> (ø)`	⬆️
simapp/config.go	`54.28% <ø> (ø)`	⬆️
x/auth/module.go	`50% <0%> (ø)`	⬆️
x/bank/module.go	`46% <0%> (ø)`	⬆️
x/distribution/module.go	`54.09% <0%> (ø)`	⬆️
x/mint/module.go	`49.01% <0%> (ø)`	⬆️
x/slashing/module.go	`55% <0%> (ø)`	⬆️
x/staking/module.go	`50.76% <0%> (ø)`	⬆️
... and 3 more

alessio

ACK. Pleae run make format.

alessio

Not all deps have been removed

simapp/state.go

…dependency

CHANGELOG.md

Co-Authored-By: Alessio Treglia <[email protected]>

x/gov/simulation/params.go

x/gov/types/content.go

x/slashing/simulation/params.go

x/staking/module.go

Co-Authored-By: Marko <[email protected]>

golangcibot · 2020-03-23T11:17:06Z

x/gov/simulation/params.go

@@ -7,9 +7,10 @@ import (
 	"fmt"
 	"math/rand"

+	"github.com/cosmos/cosmos-sdk/x/simulation"


File is not goimports-ed (from goimports)

Suggested change

"github.com/cosmos/cosmos-sdk/x/simulation"

golangcibot · 2020-03-23T11:17:06Z

x/staking/module.go

@@ -13,12 +13,12 @@ import (
 	cfg "github.com/tendermint/tendermint/config"
 	"github.com/tendermint/tendermint/crypto"

+	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"


File is not goimports-ed (from goimports)

Suggested change

simtypes "github.com/cosmos/cosmos-sdk/types/simulation"

golangcibot · 2020-03-23T11:17:46Z

x/slashing/simulation/params.go

@@ -7,6 +7,7 @@ import (
 	"math/rand"

 	"github.com/cosmos/cosmos-sdk/x/simulation"
+	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"


File is not gofmt-ed with -s (from gofmt)

Suggested change

simtypes "github.com/cosmos/cosmos-sdk/types/simulation"

simtypes "github.com/cosmos/cosmos-sdk/types/simulation"

"github.com/cosmos/cosmos-sdk/x/simulation"

tac0turtle

LGTM 🇪🇸 🐧

Closes: cosmos#5724

interface WeightedProposalContent

028875f

jgimeno self-assigned this Mar 19, 2020

jgimeno added 4 commits March 19, 2020 16:35

remove module x simulation dependency

eca372b

interface the commit

1a4df96

refactor middle step

f7efda2

refactor and test pass

381869d

golangcibot reviewed Mar 19, 2020

View reviewed changes

x/auth/simulation/params.go Outdated Show resolved Hide resolved

simapp/helpers/test_helpers.go Outdated Show resolved Hide resolved

refactor to types

b0076cb

golangcibot reviewed Mar 19, 2020

View reviewed changes

x/simulation/operation.go Outdated Show resolved Hide resolved

x/simulation/params.go Outdated Show resolved Hide resolved

x/simulation/simulate.go Outdated Show resolved Hide resolved

fix imports

0d6a228

golangcibot reviewed Mar 19, 2020

View reviewed changes

x/params/module.go Outdated Show resolved Hide resolved

x/mint/simulation/params.go Outdated Show resolved Hide resolved

jgimeno requested review from fedekunze and alessio March 20, 2020 12:10

Merge branch 'master' into jonathan/5724-module-simulation-top-level-…

22e26bb

…dependency

jgimeno added 7 commits March 20, 2020 15:50

move param changes to types to

d939b20

Merge branch 'jonathan/5724-module-simulation-top-level-dependency' o…

62e9d99

…f github.com:cosmos/cosmos-sdk into jonathan/5724-module-simulation-top-level-dependency

fix types

5e796a2

Merge branch 'master' into jonathan/5724-module-simulation-top-level-…

dde07b4

…dependency

update simulation

d94e80d

move paramchange back to simulation

9b18788

remove unused types

20ac782

jgimeno added 4 commits March 20, 2020 17:15

add some test coverage

325f7b2

add go mod tidy

37fd2f7

update changelog

eabf5c9

Merge branch 'master' into jonathan/5724-module-simulation-top-level-…

c1e956d

…dependency

jgimeno marked this pull request as ready for review March 20, 2020 17:14

jgimeno requested review from alexanderbez and hschoenburg as code owners March 20, 2020 17:14

jgimeno added R4R C:Simulations labels Mar 20, 2020

alessio approved these changes Mar 21, 2020

View reviewed changes

update with make format

6129702

alessio suggested changes Mar 21, 2020

View reviewed changes

simapp/state.go Outdated Show resolved Hide resolved

jgimeno added 2 commits March 22, 2020 13:59

avoid dependency in simapp for module simulation

2b0ec64

Merge branch 'master' into jonathan/5724-module-simulation-top-level-…

bda03c3

…dependency

alessio reviewed Mar 22, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

ccd8a95

Co-Authored-By: Alessio Treglia <[email protected]>

alessio approved these changes Mar 22, 2020

View reviewed changes

alessio requested a review from tac0turtle March 23, 2020 10:56

tac0turtle reviewed Mar 23, 2020

View reviewed changes

x/gov/simulation/params.go Outdated Show resolved Hide resolved

tac0turtle reviewed Mar 23, 2020

View reviewed changes

x/gov/types/content.go Show resolved Hide resolved

tac0turtle reviewed Mar 23, 2020

View reviewed changes

x/slashing/simulation/params.go Outdated Show resolved Hide resolved

tac0turtle reviewed Mar 23, 2020

View reviewed changes

x/staking/module.go Outdated Show resolved Hide resolved

jgimeno and others added 3 commits March 23, 2020 12:13

Update x/gov/simulation/params.go

7af823e

Co-Authored-By: Marko <[email protected]>

Update x/staking/module.go

fce2ae2

Co-Authored-By: Marko <[email protected]>

Update x/slashing/simulation/params.go

2a9c3e7

Co-Authored-By: Marko <[email protected]>

golangcibot reviewed Mar 23, 2020

View reviewed changes

tac0turtle approved these changes Mar 23, 2020

View reviewed changes

add format

33b8011

jgimeno mentioned this pull request Mar 23, 2020

gov/types/content Content interface is exactly the same as in types/simulation/types #5853

Closed

4 tasks

add issue in TODO

9cb2343

alessio merged commit 49102b1 into master Mar 23, 2020

alessio deleted the jonathan/5724-module-simulation-top-level-dependency branch March 23, 2020 11:55

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023

Remove dependency of types/module package on x/simulation (cosmos#5835)

658cd7e

Closes: cosmos#5724

Itchibon777 mentioned this pull request Dec 27, 2023

[Snyk] Security upgrade axios from 0.19.0 to 1.6.3 Itchibon777/cosmos-sdk#7

Open

Itchibon777 mentioned this pull request Jan 5, 2024

[Snyk] Security upgrade axios from 0.19.0 to 1.6.4 Itchibon777/cosmos-sdk#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency of types/module package on x/simulation #5835

Remove dependency of types/module package on x/simulation #5835

jgimeno commented Mar 19, 2020 •

edited

Loading

jgimeno commented Mar 20, 2020

codecov bot commented Mar 20, 2020 •

edited

Loading

codecov bot commented Mar 20, 2020 •

edited

Loading

alessio left a comment

alessio left a comment

golangcibot Mar 23, 2020

golangcibot Mar 23, 2020

golangcibot Mar 23, 2020

tac0turtle left a comment

	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
	"github.com/cosmos/cosmos-sdk/x/simulation"

Remove dependency of types/module package on x/simulation #5835

Remove dependency of types/module package on x/simulation #5835

Conversation

jgimeno commented Mar 19, 2020 • edited Loading

Description

jgimeno commented Mar 20, 2020

codecov bot commented Mar 20, 2020 • edited Loading

Codecov Report

codecov bot commented Mar 20, 2020 • edited Loading

Codecov Report

alessio left a comment

Choose a reason for hiding this comment

alessio left a comment

Choose a reason for hiding this comment

golangcibot Mar 23, 2020

Choose a reason for hiding this comment

golangcibot Mar 23, 2020

Choose a reason for hiding this comment

golangcibot Mar 23, 2020

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

jgimeno commented Mar 19, 2020 •

edited

Loading

codecov bot commented Mar 20, 2020 •

edited

Loading

codecov bot commented Mar 20, 2020 •

edited

Loading