crypto/keyring: change addrKey to store chain-agnostic addresses #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 24, 2020
|
This pull request introduces 1 alert when merging c8163ba into a1ac04c - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5858 +/- ##
==========================================
+ Coverage 56.75% 56.77% +0.01%
==========================================
Files 344 344
Lines 20294 20307 +13
==========================================
+ Hits 11518 11529 +11
- Misses 7895 7896 +1
- Partials 881 882 +1 |
alessio
force-pushed
the
alessio/store-keys-by-hexbytes-repr
branch
2 times, most recently
from
266ba0e
to
6819337
Compare
alessio
changed the title
crypto/keyring/keyring.go
Outdated
| @@ -581,3 +582,7 @@ func newRealPrompt(dir string, buf io.Reader) func(string) (string, error) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func addrKey(address types.AccAddress) []byte { | |||
| return []byte(fmt.Sprintf("%s.%s", hex.EncodeToString(address.Bytes()), addressSuffix)) | |||
There was a problem hiding this comment.
why encode to hex when we can just use the String interpretation?
There was a problem hiding this comment.
Because accounts types String methods depend on the notorious Config singleton
There was a problem hiding this comment.
I didn't change it for the old Keybase implementations to avoid breaking gaiacli versions used for Cosmos Hub
jgimeno
reviewed
Mar 26, 2020
jgimeno
approved these changes
Mar 26, 2020
alessio
force-pushed
the
alessio/store-keys-by-hexbytes-repr
branch
from
145e84f
to
59d58f8
Compare
added 2 commits
March 28, 2020 18:25
Keyrings store keys by name and hexbytes representation of address. This turns keyring internal storage more chain-agnostic and types.Config independent. Obsolete Keybase internal state representation is not affected.
Keyrings store keys by name and hexbytes representation of address. This turns keyring internal storage more chain-agnostic and types.Config independent. Obsolete Keybase internal state representation is not affected.
alessio
force-pushed
the
alessio/store-keys-by-hexbytes-repr
branch
from
ae0c933
to
7a74fe4
Compare
|
@alexanderbez comments have been incorporated, please review again when you spare a minute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyrings store keys by name and hexbytes representation
of address. This turns keyring internal storage more
chain-agnostic and types.Config independent.
Obsolete Keybase internal state representation is not affected.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)