Fix validate cmd bug #5920
Merged
Fix validate cmd bug #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
golangcibot
reviewed
Apr 2, 2020
client/cmd.go
Outdated
| for _, s := range suggestions { | ||
| err += fmt.Sprintf("\t%v\n", s) | ||
| // check if the current arg is a flag | ||
| if len(arg) > 0 && (arg[0] == '-') { |
There was a problem hiding this comment.
ifElseChain: rewrite if-else to switch statement (from gocritic)
|
@colin-axner I've updated Gaia to work with the latest master (e0c1774). Please go ahead and test these changes along with addressing any lint issues. Thanks for taking this up! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #5920 +/- ##
==========================================
+ Coverage 56.48% 57.06% +0.58%
==========================================
Files 342 342
Lines 20261 20064 -197
==========================================
+ Hits 11444 11450 +6
+ Misses 7972 7768 -204
- Partials 845 846 +1
|
|
@colin-axner lmk when this is R4R again. |
|
@alexanderbez it's R4R, I tested locally with latest gaia version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5919
Description
updates validateCmd to search for the unknown command, ignoring any flags and their values and returning the help screen if the help flags are an argument.
untested at the moment.. having trouble installing via gaia because this branch is on the latest sdk version which has build issues on gaia
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)