Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Port Binding for Transfer Module #6011

Merged
merged 10 commits into from
Apr 17, 2020
Merged

Conversation

AdityaSripal
Copy link
Member

Description

Allows transfer module to bind to portID =/= "transfer" by specifying the portID in the genesis state.

Removes check in channel callbacks


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #6011 into master will decrease coverage by 0.02%.
The diff coverage is 32.14%.

@@            Coverage Diff             @@
##           master    #6011      +/-   ##
==========================================
- Coverage   55.32%   55.29%   -0.03%     
==========================================
  Files         428      429       +1     
  Lines       25548    25562      +14     
==========================================
+ Hits        14134    14135       +1     
- Misses      10441    10454      +13     
  Partials      973      973              

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdityaSripal !

x/ibc/20-transfer/genesis.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/genesis.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/genesis.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/genesis.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/genesis.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/module.go Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo @fedekunze comments

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/ibc/20-transfer/types/codec.go Outdated Show resolved Hide resolved
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 17, 2020
@mergify mergify bot merged commit 54f8666 into master Apr 17, 2020
@mergify mergify bot deleted the aditya/flexible-port branch April 17, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants