Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.37.10 #6045

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Release v0.37.10 #6045

merged 5 commits into from
Apr 22, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 21, 2020

Bugfix only release.

Closes: #5964


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #6045 into release/v0.37.10 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           release/v0.37.10    #6045      +/-   ##
====================================================
- Coverage             51.36%   51.34%   -0.03%     
====================================================
  Files                   290      290              
  Lines                 18900    18900              
====================================================
- Hits                   9708     9704       -4     
- Misses                 8499     8503       +4     
  Partials                693      693              

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (assuming the fix is on master too).

@alessio pls update Gaia and create a release there too.

@alessio
Copy link
Contributor Author

alessio commented Apr 21, 2020

master significantly diverged from the 0.37 series - plus #5982 fixed various things in master. Lastly, the bug seems non-reproducible in 0.38 (and thanks for the review!)

@alexanderbez
Copy link
Contributor

master significantly diverged from the 0.37 series - plus #5982 fixed various things in master. Lastly, the bug seems non-reproducible in 0.38 (and thanks for the review!)

I'm not referring to 0.37, I'm referring to the specific cherry-picks/commits found in this point release. 👍

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jackzampolin
Copy link
Member

@alexanderbez I've still got the pending ibc-alpha branch on gaia which isn't quite ready to merge into master. Want to ensure that its passing all the relayer tests first. Or we can merge and restart theibc-alpha branch. Which ever works for y'all

@alessio
Copy link
Contributor Author

alessio commented Apr 22, 2020

@jackzampolin this does not go to master

@alessio alessio merged commit 6162c5b into release/v0.37.10 Apr 22, 2020
@alessio alessio deleted the rc0/v0.37.10 branch April 22, 2020 07:51
@jackzampolin
Copy link
Member

Duh. Thank you @alessio 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants