Start global capability index at 1 #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6047 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 424 424
Lines 25808 25814 +6
=======================================
+ Hits 14115 14119 +4
- Misses 10716 10717 +1
- Partials 977 978 +1 |
cwgoes
reviewed
Apr 22, 2020
| @@ -98,7 +98,10 @@ func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} | |||
|
|
|||
| // InitGenesis performs the capability module's genesis initialization It returns | |||
| // no validator updates. | |||
| func (am AppModule) InitGenesis(_ sdk.Context, _ codec.JSONMarshaler, _ json.RawMessage) []abci.ValidatorUpdate { | |||
| func (am AppModule) InitGenesis(ctx sdk.Context, _ codec.JSONMarshaler, _ json.RawMessage) []abci.ValidatorUpdate { | |||
There was a problem hiding this comment.
Won't this be run after port binding in app.go? That seems problematic
There was a problem hiding this comment.
... never mind - however, somehow, this is not being called
4 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* start index at 1 * Update x/capability/keeper/keeper.go Co-authored-by: Federico Kunze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6039
Description
An annoying quirk in the capability testing setup prevented us from catching the bug reported above. Created a new testcase
TestOriginalCapabilityKeeperthat reproduced the failure above and is now passing.Created
InitGenesislogic to set initial global index to 1For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)