Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cli tests for staking module #6347

Merged
merged 24 commits into from
Jun 13, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 5, 2020

Description

This add missing tests for staking cli which are absent in gaia/cli_test
Reference - #5951

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6347 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6347   +/-   ##
=======================================
  Coverage   55.72%   55.72%           
=======================================
  Files         465      465           
  Lines       27782    27782           
=======================================
  Hits        15481    15481           
  Misses      11197    11197           
  Partials     1104     1104           

@atheeshp
Copy link
Contributor Author

@anilcse @aaronc,
We have an issue with UnmarshalBinaryBare here: https://github.com/cosmos/cosmos-sdk/blob/master/x/staking/client/cli/query.go#L402
but if we use UnmarshalJSON instead of UnmarshalBinaryBare it is giving expected output.
When we use UnmarshBinaryBare the command is returning with following error:
ERROR: proto: illegal wireType 7

@alexanderbez
Copy link
Contributor

Note @atheeshp all queries and client logic use JSON over binary.

@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
@anilcse anilcse marked this pull request as ready for review June 11, 2020 17:05
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze added R4R and removed C:CLI labels Jun 12, 2020
@fedekunze fedekunze added A:automerge Automatically merge PR once all prerequisites pass. and removed WIP labels Jun 13, 2020
@mergify mergify bot merged commit 6a0ac5b into master Jun 13, 2020
@mergify mergify bot deleted the atheesh/missing-staking-cli-tests branch June 13, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants