Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf Tx unit tests #6614

Merged
merged 13 commits into from
Jul 23, 2020
Merged

Add protobuf Tx unit tests #6614

merged 13 commits into from
Jul 23, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 6, 2020

ref: #6213

This PR adds separate test configurations for protobuf and amino transactions. Currently amino transactions will remain as the default for tests, but that will switch after protobuf transactions are fully tested. This is needed to finish testing on #6717 and #6734. Once those are merged and make test-unit-proto passes, that will be switched to the default test config.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #6614 into master will increase coverage by 1.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6614      +/-   ##
==========================================
+ Coverage   60.26%   61.42%   +1.15%     
==========================================
  Files         390      509     +119     
  Lines       25331    31457    +6126     
==========================================
+ Hits        15266    19321    +4055     
- Misses       8897    10637    +1740     
- Partials     1168     1499     +331     

@ethanfrey
Copy link
Contributor

What is the status here?

Since #6423 and #6571 have been closed, this seems the last blocker to begin updating clients to the new "stargate" API.

It doesn't seem there has been movement in almost 2 weeks. I assume it is blocked by some of the other parts of #6213

I'd be happy for a quick update and any ETA on this to help with planning

@aaronc
Copy link
Member Author

aaronc commented Jul 21, 2020

@ethanfrey This is blocked on #6717 and #6734. I think those are pretty close. I will pick this up again after those are merged in.

@aaronc aaronc changed the title DNM: Enable protobuf TxGenerator Add protobuf Tx unit tests Jul 23, 2020
@aaronc
Copy link
Member Author

aaronc commented Jul 23, 2020

We've decided to move forward with this now so that make test-unit-proto can be called to help finish up #6717 and #6734. The CI config will be switched over after those are merged.

@aaronc aaronc marked this pull request as ready for review July 23, 2020 16:46
@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 23, 2020
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 0a498d8 into master Jul 23, 2020
@mergify mergify bot deleted the aaronc/6213-enable-proto-tx branch July 23, 2020 17:31
@ethanfrey
Copy link
Contributor

Nice

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Enable proto tx by default and add test_amino build flag.

* Enable proto TxDecoder

* update makefile

* fix conflicts

* Revert AminoCodec change

* Make test-unit-amino default for now

* Make test-unit-amino default for now

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: sahith-narahari <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants