Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/staking/simulation/operations.go: add unit tests #6690

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 11, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #6690 into master will decrease coverage by 2.37%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6690      +/-   ##
==========================================
- Coverage   57.48%   55.11%   -2.38%     
==========================================
  Files         505      338     -167     
  Lines       30710    19460   -11250     
==========================================
- Hits        17655    10725    -6930     
+ Misses      11768     7978    -3790     
+ Partials     1287      757     -530     

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 11, 2020
@dauTT dauTT mentioned this pull request Jul 11, 2020
8 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit 3ab823c into cosmos:master Jul 12, 2020
@dauTT dauTT deleted the staking-sim-test-operation-5007 branch July 12, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants