Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/slashing/simulation/params.go: add unit tests #6698

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 12, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #6698 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6698      +/-   ##
==========================================
- Coverage   58.63%   58.36%   -0.28%     
==========================================
  Files         413      507      +94     
  Lines       24557    30743    +6186     
==========================================
+ Hits        14399    17943    +3544     
- Misses       8996    11469    +2473     
- Partials     1162     1331     +169     

@fedekunze fedekunze added A:automerge Automatically merge PR once all prerequisites pass. C:Simulations T: Tests labels Jul 13, 2020
@mergify mergify bot merged commit 1caf917 into cosmos:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants