Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc-transfer/simulation/genesis.go: add unit tests #6709

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 13, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #6709 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
+ Coverage   58.38%   58.39%   +0.01%     
==========================================
  Files         507      508       +1     
  Lines       30743    30752       +9     
==========================================
+ Hits        17950    17959       +9     
  Misses      11462    11462              
  Partials     1331     1331              

@dauTT dauTT mentioned this pull request Jul 13, 2020
8 tasks
@fedekunze fedekunze merged commit 7678f8a into cosmos:master Jul 13, 2020
@dauTT dauTT deleted the ibc-transfer-sim-genesi-5007 branch July 13, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants