Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gov/simulation/operations.go: add unit tests #6723

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 14, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dauTT dauTT mentioned this pull request Jul 14, 2020
8 tasks
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #6723 into master will increase coverage by 3.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6723      +/-   ##
==========================================
+ Coverage   55.94%   59.81%   +3.86%     
==========================================
  Files         345      512     +167     
  Lines       20023    31299   +11276     
==========================================
+ Hits        11202    18721    +7519     
- Misses       7994    11153    +3159     
- Partials      827     1425     +598     

@fedekunze fedekunze merged commit 6f928e1 into cosmos:master Jul 15, 2020
@dauTT dauTT deleted the gov-sim-test-operations-5007 branch July 15, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants