Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gov/simulation/proposals.go: add unit tests #6737

Merged
merged 5 commits into from
Jul 16, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 15, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #6737 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
+ Coverage   59.66%   59.85%   +0.18%     
==========================================
  Files         418      512      +94     
  Lines       25070    31303    +6233     
==========================================
+ Hits        14959    18737    +3778     
- Misses       8867    11143    +2276     
- Partials     1244     1423     +179     

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@dauTT dauTT mentioned this pull request Jul 15, 2020
8 tasks
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 16, 2020
@mergify mergify bot merged commit ab162a6 into cosmos:master Jul 16, 2020
@dauTT dauTT deleted the gov-sim-test-proposals-5007 branch July 18, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants