Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/evidence/simulation/genesis.go: add unit tests #6740

Merged
merged 8 commits into from
Jul 16, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 15, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #6740 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6740      +/-   ##
==========================================
- Coverage   59.94%   59.66%   -0.28%     
==========================================
  Files         513      418      -95     
  Lines       31434    25070    -6364     
==========================================
- Hits        18842    14959    -3883     
+ Misses      11156     8867    -2289     
+ Partials     1436     1244     -192     

@dauTT dauTT mentioned this pull request Jul 15, 2020
8 tasks
@fedekunze
Copy link
Collaborator

linter is failing

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 16, 2020
@mergify mergify bot merged commit ebc3ad6 into cosmos:master Jul 16, 2020
@dauTT dauTT deleted the evidence-sim-test-5007 branch July 18, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants