Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/capability/simulation/genesis.go: add unit tests #6770

Merged
merged 3 commits into from
Jul 18, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 18, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #6770 into master will decrease coverage by 2.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6770      +/-   ##
==========================================
- Coverage   62.76%   59.89%   -2.88%     
==========================================
  Files         386      513     +127     
  Lines       23910    31491    +7581     
==========================================
+ Hits        15008    18861    +3853     
- Misses       7810    11192    +3382     
- Partials     1092     1438     +346     

@alexanderbez alexanderbez merged commit 0033f24 into cosmos:master Jul 18, 2020
@dauTT dauTT deleted the cap-sim-test-geneis-5007 branch July 18, 2020 18:29
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants