Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pieces of x/genutil missed in #6734 #6860

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 27, 2020

ref: #6213


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #6860 into master will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #6860      +/-   ##
==========================================
- Coverage   61.55%   61.54%   -0.01%     
==========================================
  Files         509      508       -1     
  Lines       31525    31523       -2     
==========================================
- Hits        19406    19402       -4     
- Misses      10610    10611       +1     
- Partials     1509     1510       +1     

@aaronc aaronc mentioned this pull request Jul 27, 2020
16 tasks
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 27, 2020
@mergify mergify bot merged commit bb8aabd into master Jul 27, 2020
@mergify mergify bot deleted the aaronc/6213-genutil-fixes branch July 27, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants