Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/{capability, genutil} genesis types migrated to proto #6867

Merged
merged 13 commits into from
Jul 29, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 28, 2020

ref : #5917

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #6867 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6867   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         509      509           
  Lines       31625    31625           
=======================================
  Hits        19386    19386           
  Misses      10725    10725           
  Partials     1514     1514           

@atheeshp atheeshp changed the title x/capability genesis types migrated to proto x/{capability, genutil} genesis types migrated to proto Jul 28, 2020
@aaronc aaronc mentioned this pull request Jul 28, 2020
16 tasks
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

proto/cosmos/capability/genesis.proto Outdated Show resolved Hide resolved
proto/cosmos/capability/genesis.proto Outdated Show resolved Hide resolved
proto/cosmos/genutil/genesis.proto Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from fedekunze July 29, 2020 13:31
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronc aaronc added C:Encoding C:x/capability C:x/genutil genutil module issues A:automerge Automatically merge PR once all prerequisites pass. labels Jul 29, 2020
@fedekunze fedekunze added the C:genesis relating to chain genesis label Jul 29, 2020
@mergify mergify bot merged commit a4d1f30 into master Jul 29, 2020
@mergify mergify bot deleted the atheesh/5917-genesis-proto-migration branch July 29, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding C:genesis relating to chain genesis C:x/capability C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants