0.39.1 Release #6921

alessio · 2020-08-03T09:18:38Z

Release PR for reviewers convenience.

Please don't merge this.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

This adds the --unsafe-cors flag functionality. From: #5671 Co-authored-by: Marko <[email protected]>

…g for Accounts"

codecov · 2020-08-03T09:33:54Z

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.39.1@89ceb62). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release/v0.39.1    #6921   +/-   ##
==================================================
  Coverage                   ?   51.51%           
==================================================
  Files                      ?      338           
  Lines                      ?    20585           
  Branches                   ?        0           
==================================================
  Hits                       ?    10605           
  Misses                     ?     9185           
  Partials                   ?      795

x/auth/legacy/v0_38/types.go

x/auth/legacy/v0_39/types.go

alexanderbez · 2020-08-04T14:09:37Z

What's blocking here @alessio. Has this been sufficiently tested? Are we ready to cut the release?

x/auth/legacy/v0_39/types.go

alessio · 2020-08-04T15:20:33Z

@alexanderbez we're waiting for clients to provide bugfix verification

ethanfrey · 2020-08-04T16:58:59Z

Verification for fix is in!

I would love a unit test for genesis migration, including a long bech32 multisig address, so we have more confidence there will not be other issues with other nets.

After that 👍 to merge

alessio · 2020-08-04T17:39:47Z

Tests are failing, here is an excerpt of the log:

2020-08-04T14:06:25.8265965Z --- FAIL: TestMigrate (0.00s)
2020-08-04T14:06:25.8266733Z     migrate_test.go:118: 
2020-08-04T14:06:25.8267242Z         	Error Trace:	migrate_test.go:118
2020-08-04T14:06:25.8267760Z         	Error:      	func (assert.PanicTestFunc)(0x11ebfe0) should not panic
2020-08-04T14:06:25.8268602Z         	            		Panic value:	unrecognized concrete type name cosmos-sdk/BaseAccount
2020-08-04T14:06:25.8269471Z         	            		Panic stack:	goroutine 12 [running]:
2020-08-04T14:06:25.8270260Z         	            	runtime/debug.Stack(0xc0004e5cf6, 0x12a8560, 0xc00035c530)
2020-08-04T14:06:25.8270895Z         	            		/opt/hostedtoolcache/go/1.14.6/x64/src/runtime/debug/stack.go:24 +0xab
2020-08-04T14:06:25.8271467Z         	            	github.com/stretchr/testify/assert.didPanic.func1.1(0xc0004e5d28, 0xc0004e5cf6, 0xc0004e5d18)
2020-08-04T14:06:25.8272096Z         	            		/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1013 +0xc0
2020-08-04T14:06:25.8272664Z         	            	panic(0x12a8560, 0xc00035c530)
2020-08-04T14:06:25.8273212Z         	            		/opt/hostedtoolcache/go/1.14.6/x64/src/runtime/panic.go:975 +0x3e3
2020-08-04T14:06:25.8274068Z         	            	github.com/tendermint/go-amino.(*Codec).MustUnmarshalJSON(...)
2020-08-04T14:06:25.8275218Z         	            		/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/amino.go:445
2020-08-04T14:06:25.8276151Z         	            	github.com/cosmos/cosmos-sdk/x/genutil/legacy/v0_39.Migrate(0xc000343110, 0x7fca50090008)
2020-08-04T14:06:25.8278380Z         	            		/home/runner/work/cosmos-sdk/cosmos-sdk/x/genutil/legacy/v0_39/migrate.go:26 +0x8c1
2020-08-04T14:06:25.8279840Z         	            	github.com/cosmos/cosmos-sdk/x/genutil/legacy/v0_39_test.TestMigrate.func1()
2020-08-04T14:06:25.8280999Z         	            		/home/runner/work/cosmos-sdk/cosmos-sdk/x/genutil/legacy/v0_39/migrate_test.go:118 +0x4f
2020-08-04T14:06:25.8281626Z         	            	github.com/stretchr/testify/assert.didPanic.func1(0xc000065d28, 0xc000065cf6, 0xc000065d18, 0xc000340ca0)
2020-08-04T14:06:25.8282844Z         	            		/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1018 +0x8c
2020-08-04T14:06:25.8283518Z         	            	github.com/stretchr/testify/assert.didPanic(0xc000340ca0, 0x7fca4fd06190, 0xc0005799e0, 0x7fca4fd061b0, 0xc0005799e0, 0x1)
2020-08-04T14:06:25.8284131Z         	            		/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1020 +0x6d
2020-08-04T14:06:25.8284715Z         	            	github.com/stretchr/testify/assert.NotPanics(0x7fca4fd06190, 0xc0005799e0, 0xc000340ca0, 0x0, 0x0, 0x0, 0xc000340ca0)
2020-08-04T14:06:25.8285301Z         	            		/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1091 +0x90
2020-08-04T14:06:25.8285860Z         	            	github.com/stretchr/testify/require.NotPanics(0x16a83e0, 0xc0005799e0, 0xc000340ca0, 0x0, 0x0, 0x0)
2020-08-04T14:06:25.8286435Z         	            		/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/require/require.go:1236 +0xcc
2020-08-04T14:06:25.8287402Z         	            	github.com/cosmos/cosmos-sdk/x/genutil/legacy/v0_39_test.TestMigrate(0xc0005799e0)
2020-08-04T14:06:25.8288482Z         	            		/home/runner/work/cosmos-sdk/cosmos-sdk/x/genutil/legacy/v0_39/migrate_test.go:118 +0x202
2020-08-04T14:06:25.8289089Z         	            	testing.tRunner(0xc0005799e0, 0x15429b8)
2020-08-04T14:06:25.8289659Z         	            		/opt/hostedtoolcache/go/1.14.6/x64/src/testing/testing.go:1039 +0x1ec
2020-08-04T14:06:25.8290189Z         	            	created by testing.(*T).Run
2020-08-04T14:06:25.8290725Z         	            		/opt/hostedtoolcache/go/1.14.6/x64/src/testing/testing.go:1090 +0x701
2020-08-04T14:06:25.8291236Z         	Test:       	TestMigrate
2020-08-04T14:06:25.8291570Z FAIL
2020-08-04T14:06:25.8292100Z coverage: 91.7% of statements
2020-08-04T14:06:25.8292832Z FAIL	github.com/cosmos/cosmos-sdk/x/genutil/legacy/v0_39	0.832s

alessio · 2020-08-04T18:50:45Z

#6938 should fix the v0.39 migration test case

anilcse

lgtm

Co-authored-by: Alexander Bezobchuk <[email protected]>

alessio · 2020-08-05T08:17:05Z

I'll tag another release candidate and ask clients to test again shortly

jgimeno

LGTM

jgimeno

Waiting for approval from Cory and Ethan.

jgimeno

Waiting for approval from @clevinson and @ethanfrey .

ethanfrey

ACK

RELEASE_NOTES.md

clevinson

ack

SRMs approval process has finished

alessio · 2020-08-11T23:22:48Z

Sims are green, hence releasing. Thanks all

alexanderbez and others added 6 commits July 25, 2020 20:50

Merge PR #6842: Remove custom acc JSON marshl

7b931e2

Backport #5671: Add a Flag for CORS (#6853)

302487c

This adds the --unsafe-cors flag functionality. From: #5671 Co-authored-by: Marko <[email protected]>

Merge PR #6855: Allow passing through Content-Type (needed for POST)

9d00f71

Merge PR #6861: Revert "Backport 0.39.1: Remove Custom JSON Marshalin…

b0ab544

…g for Accounts"

Merge PR #6869: Backport 0.39.1: Launchpad Migration #6829

e82246e

Update changelog and release notes

dc212ec

alessio requested review from alexanderbez, fedekunze and jackzampolin as code owners August 3, 2020 09:18

alexanderbez reviewed Aug 3, 2020

View reviewed changes

x/auth/legacy/v0_38/types.go Outdated Show resolved Hide resolved

alexanderbez reviewed Aug 3, 2020

View reviewed changes

x/auth/legacy/v0_39/types.go Outdated Show resolved Hide resolved

alexanderbez mentioned this pull request Aug 4, 2020

v0.39 auth migration panics with v0.38 accounts #6931

Closed

4 tasks

alexanderbez added 2 commits August 4, 2020 09:59

Update x/auth/legacy/v0_39/types.go

d92a491

Update x/auth/legacy/v0_38/types.go

9b94892

alexanderbez approved these changes Aug 4, 2020

View reviewed changes

alexanderbez requested review from aaronc, AdityaSripal, amaury1093 and jgimeno August 4, 2020 14:09

alexanderbez changed the title ~~Backport/v0.39.x~~ 0.39.1 Release Aug 4, 2020

alexanderbez reviewed Aug 4, 2020

View reviewed changes

x/auth/legacy/v0_39/types.go Outdated Show resolved Hide resolved

Alessio Treglia added 2 commits August 4, 2020 15:16

Merge PR #6938: Fix v0.39 migrate test

9beb119

Merge PR #6937: Bump Tendermint to v0.33.7

65ec8e6

anilcse approved these changes Aug 4, 2020

View reviewed changes

Update x/auth/legacy/v0_39/types.go

8084428

Co-authored-by: Alexander Bezobchuk <[email protected]>

jgimeno approved these changes Aug 5, 2020

View reviewed changes

jgimeno reviewed Aug 5, 2020

View reviewed changes

jgimeno previously requested changes Aug 5, 2020

View reviewed changes

Alessio Treglia added 2 commits August 11, 2020 13:45

update RELEASE_NOTES.md

1efac36

update changelog

a6ab122

ethanfrey approved these changes Aug 11, 2020

View reviewed changes

RELEASE_NOTES.md Outdated Show resolved Hide resolved

Alessio Treglia added 2 commits August 11, 2020 19:11

test case with real genesis data (#6995)

b903c4a

incorporate Ethan Frey's suggestion

3e263c8

alessio requested a review from clevinson August 11, 2020 18:27

clevinson approved these changes Aug 11, 2020

View reviewed changes

alessio merged commit 6a624c3 into release/v0.39.1 Aug 11, 2020

alessio deleted the backport/v0.39.x branch August 11, 2020 23:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.39.1 Release #6921

0.39.1 Release #6921

alessio commented Aug 3, 2020 •

edited

Loading

codecov bot commented Aug 3, 2020 •

edited

Loading

alexanderbez commented Aug 4, 2020

alessio commented Aug 4, 2020

ethanfrey commented Aug 4, 2020

alessio commented Aug 4, 2020

alessio commented Aug 4, 2020

anilcse left a comment

alessio commented Aug 5, 2020

jgimeno left a comment

jgimeno left a comment

jgimeno left a comment

ethanfrey left a comment

clevinson left a comment

alessio commented Aug 11, 2020

0.39.1 Release #6921

0.39.1 Release #6921

Conversation

alessio commented Aug 3, 2020 • edited Loading

codecov bot commented Aug 3, 2020 • edited Loading

Codecov Report

alexanderbez commented Aug 4, 2020

alessio commented Aug 4, 2020

ethanfrey commented Aug 4, 2020

alessio commented Aug 4, 2020

alessio commented Aug 4, 2020

anilcse left a comment

Choose a reason for hiding this comment

alessio commented Aug 5, 2020

jgimeno left a comment

Choose a reason for hiding this comment

jgimeno left a comment

Choose a reason for hiding this comment

jgimeno left a comment

Choose a reason for hiding this comment

ethanfrey left a comment

Choose a reason for hiding this comment

clevinson left a comment

Choose a reason for hiding this comment

alessio commented Aug 11, 2020

alessio commented Aug 3, 2020 •

edited

Loading

codecov bot commented Aug 3, 2020 •

edited

Loading