Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add height in exported genesis #7089
Add height in exported genesis #7089
Changes from 18 commits
7b56ee3
167cc8b
e17275c
ef1e6f0
64e828b
a04a42c
a619220
2c7ef98
1749ca8
2b1cec3
facab0e
a4ac0fc
6a9e6bc
a04b438
bf549ec
86162b3
fb99bb3
bf9d606
405c921
270c323
5df1626
9d16e9e
af9e5dc
9274552
5dfa955
4aa9bcc
bcbb243
7fdab5d
6839081
0b82fec
ca6b7c1
7f0b573
4c858a5
76c7a12
b80e01b
eb65bd1
10bc9e6
314f0a3
255aaa7
f6216f6
1f1b602
789842a
fac4d5e
b532d0d
6ab3cf9
54b0a97
e62a650
c95c075
dbc92b7
e238ebe
b8ba3e2
57485ee
7c6ba4d
ecd6d7a
66a0dc8
f7cd6d2
af26c5b
5c5b3eb
31d2986
57c1f9f
2b28235
aeec99f
c2d41b5
d7f4353
5940b66
95365dc
788fb8b
6bf735c
8712d04
abdfb85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this not correctly implemented before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol wow.....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shortcut for
app.cms.MountStoreWithDB
, but in the code we always useapp.cms.MountStoreWithDB
directly. This function was never.called.