Allow localhost to be created #7148
Conversation
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7148 +/- ##
==========================================
+ Coverage 54.72% 54.74% +0.02%
==========================================
Files 563 563
Lines 38405 38405
==========================================
+ Hits 21016 21024 +8
+ Misses 15681 15671 -10
- Partials 1708 1710 +2 |
| @@ -147,7 +156,6 @@ func (suite *KeeperTestSuite) TestQueryClientStates() { | |||
| for i := range expClientStates { | |||
| suite.Require().Equal(expClientStates[i].ClientId, res.ClientStates[i].ClientId) | |||
| suite.Require().NotNil(res.ClientStates[i].ClientState) | |||
| expClientStates[i].ClientState.ClearCachedValue() | |||
There was a problem hiding this comment.
I had to do this bc the Equal statement would fail if the expected response had the value cached. Using Proto equal would work too
There was a problem hiding this comment.
It passes now when using the testing package. Going to leave as is but we can add back if necessary
fedekunze
added
the
A:automerge
| @@ -13,12 +13,6 @@ func (suite *ClientTestSuite) TestHandleCreateClientLocalHost() { | |||
| msg exported.MsgCreateClient | |||
| expPass bool | |||
| }{ | |||
| { | |||
| "localhost", | |||
There was a problem hiding this comment.
Why is this test-case removed?
There was a problem hiding this comment.
localhost is already created in genesis. This test would fail, changing it to false would just make it a duplication of the later test case "client already exists",
|
Hmm, I don't think we should have automerged this, but I guess its fine. |
Description
reverts changes in: #6974
closes: #6975
I had a hunch #7000 fixed this so decided to give it a shot. Locally works except for an existing issue in after import. We should not merge this until that is fixed and all sims pass.
A default genesis state creates a localhost. ExportGenesis sets "CreateLocalhost" to false because any created localhost will be exported with the clients. I'm pretty sure an exported/import with this set to true would cause panics since the localhost would be set but then the init genesis would try to create another localhost
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes