feat: allow "any" to specify a "binary" with no arch/os dependencies #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7230 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 584 584
Lines 40566 40566
=======================================
Hits 22866 22866
Misses 15773 15773
Partials 1927 1927 |
2 tasks
alessio
reviewed
Sep 3, 2020
alessio
reviewed
Sep 3, 2020
alessio
reviewed
Sep 3, 2020
alessio
reviewed
Sep 3, 2020
michaelfig
force-pushed
the
mfig/cosmovisor-any-arch
branch
from
89f32db
to
70e53df
Compare
michaelfig
changed the title
alessio
approved these changes
Sep 3, 2020
|
@michaelfig mind rebasing to master? |
Done! |
michaelfig
force-pushed
the
mfig/cosmovisor-any-arch
branch
from
9185252
to
2926645
Compare
|
@michaelfig please merge master again - sorry about the inconvenience |
sahith-narahari
approved these changes
Sep 13, 2020
sahith-narahari
added
the
A:automerge
michaelfig
force-pushed
the
mfig/cosmovisor-any-arch
branch
from
2926645
to
e2118c4
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a tiny feature for
cosmovisorto allow the "binary" info to specify a portablescript by using "any" as the default architecture if there is no specific match.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes