ibc: metrics #7441
Merged
ibc: metrics #7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7441 +/- ##
==========================================
- Coverage 58.02% 57.71% -0.31%
==========================================
Files 306 439 +133
Lines 19484 27547 +8063
==========================================
+ Hits 11305 15900 +4595
- Misses 6971 10091 +3120
- Partials 1208 1556 +348 |
alexanderbez
reviewed
Oct 2, 2020
fedekunze
requested review from
alexanderbez,
colin-axner,
AdityaSripal,
cwgoes,
amaury1093,
blushi and
clevinson
colin-axner
reviewed
Oct 5, 2020
| []string{"ibc", types.ModuleName, "receive"}, | ||
| 1, | ||
| []metrics.Label{ | ||
| telemetry.NewLabel("chain_id", ctx.ChainID()), |
There was a problem hiding this comment.
why the chain ID? this would never change
There was a problem hiding this comment.
👍 although it would be useful to retrieve the chain_id from the counterparty chain? Would that be better?
There was a problem hiding this comment.
yea that makes a lot more sense
Co-authored-by: colin axnér <[email protected]>
…into fedekunze/ibc-metrics
colin-axner
reviewed
Oct 6, 2020
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds metric for the IBC module. For a full list see here.
It also updates some logs that had wrong format
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes