Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible handshake followup #7454

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Flexible handshake followup #7454

merged 4 commits into from
Oct 5, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Oct 5, 2020 •
edited
Loading

Description

rename provedID to counterpartyChosenID for connection and channel. Ref: comment

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner
rename provedID
2fde5f2 
rename provedID to counterpartyChosenID for connection and channel. Update if statement in handshake and tests. Ref: #7439 (comment)
@colin-axner colin-axner added this to the IBC 1.0 [Implementation] milestone Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #7454 into master will not change coverage.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##           master    #7454   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         588      588           
  Lines       36800    36800           
=======================================
  Hits        20284    20284           
  Misses      14415    14415           
  Partials     2101     2101

@colin-axner colin-axner added x/ibc Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Oct 5, 2020
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 5, 2020
cwgoes
cwgoes approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Spec changes made in cosmos/ibc@2acb6cb

@mergify mergify bot merged commit 6fa8330 into master Oct 5, 2020
@mergify mergify bot deleted the colin/handshake branch October 5, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-axner @cwgoes @fedekunze